Temporary branch to investigate e2e test failures while upgrading eth-bridge-integration to v0.8.1
#716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y won't start however
This inverts the wrapping of errors, storage_api::Error now wraps NativeVp:Error and some other IBC and PoS custom errors
* namada/tomas/sorted-prefix-iter: [ci skip] wasm checksums update changelog: add #458 tests: extend prefix iter tests for reverse order add support for rev_iter_prefix in storage and VP and tx envs test/vm_host_env: check prefix iter order in tx and VP shared/storage/key: add support for int/uint keys that maintain order deps: replace hex with data-encoding changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #331 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait update wasm checksums ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type [ci skip] wasm checksums update update wasm checksums wasm_for_tests: make Update shared/src/ledger/vp_env.rs changelog: add #1093 wasm: improve error handling macros: add error handling to transaction and validity_predicate macros wasm: update for VM API changes tests: update for VM API changes VM: move vm_env sub-mod into tx/vp_prelude and add Tx/VpEnv and Ctx shared: update native_vp implementations for VpEnv methods shared/ledger/native_vp: implement VpEnv shared/vm: rename host_env TxEnv/VpEnv to TxVmEnv/VpVmEnv ledger: add tx and VP traits with host env functions
* tomas/vp-tx-env-concrete-error: changelog: add #465 [ci skip] wasm checksums update ledger: use storage_api::Error in VpEnv and TxEnv instead of generic update wasm checksums changelog: add #380 shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors
…terop/ethbridge/merge-0.8.1 * james/mainline/dont-spawn-internal-account-vps: Remove comment Update spawn_accounts to ignore implicit addresses Add changelog TestTxEnv::spawn_accounts should ignore internal addresses
This reverts commit 91f2fcb.
james-chf
changed the base branch from
eth-bridge-integration
to
interop/ethbridge/merge-0.8.1
james-chf
changed the base branch from
interop/ethbridge/merge-0.8.1
to
eth-bridge-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #704 but targeting
eth-bridge-integrationso that CI can mergeThe last thing before PR #704 can merge is to fix the e2e tests, which I've spent a fair bit of time debugging although am not making too much progress.
Most of the investigation in this PR is happening with the
pos_init_validatore2e test.namada/tests/src/e2e/ledger_tests.rs
Line 782 in d1a5fd1
It looks like there is an issue where if you create a validator account using some form of
namadac init-validator, the ledger at some point later on (i.e. not necessarily immediately) is not able to read it:In this case, there is something written to
#atest1v9hx7w362pex7mmxyphkvgznw3skkefqyqszqgpqyqszqgpqyqszqgpqyqszqgpqyqszqgpqq8ylv7/validator/#atest1v4ehgw36g4pyg3j9x3qnjd3cxgmyz3fk8qcrys3hxdp5xwfnx3zyxsj9xgunxsfjg5u5xvzyzrrqtn/eth_hot_key, but it is not deserializable to the expected type (types::ValidatorEthKey<Self::PublicKey>). This issue doesn't occur for the genesis validator'seth_hot_key, which deserializes fine, so there may be some mismatch between thewrite_validator_eth_hot_keyused in thetx_init_validatorwasm and the nativeread_validator_eth_hot_keythat is part ofimpl PosBase for Storage<D, H>. The nativewrite_validator_eth_hot_keythat is part ofimpl PosBase for Storage<D, H>seems to work fine.